url: fix return code for OOM in parse_proxy() #19779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
augment review |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
lib/url.c
Outdated
| uc = curl_url_get(uhp, CURLUPART_USER, &proxyuser, CURLU_URLDECODE); | ||
| if(uc && (uc != CURLUE_NO_USER)) | ||
| if(uc && (uc != CURLUE_NO_USER)) { | ||
| result = CURLE_OUT_OF_MEMORY; |
There was a problem hiding this comment.
Setting result to CURLE_OUT_OF_MEMORY for any curl_url_get error (other than CURLUE_NO_USER) may misreport non-OOM failures, e.g., CURLUE_URLDECODE on bad %-encoding. Consider only mapping CURLUE_OUT_OF_MEMORY to CURLE_OUT_OF_MEMORY and handling other CURLU errors appropriately (also applies to the password case below).
🤖 Was this useful? React with 👍 or 👎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.