Skip to content

openssl: don't use old BORINGSSL_YYYYMM macros - #1979

Closed
davidben wants to merge 1 commit into
curl:masterfrom
davidben:fix-ifdef
Closed

openssl: don't use old BORINGSSL_YYYYMM macros#1979
davidben wants to merge 1 commit into
curl:masterfrom
davidben:fix-ifdef

Conversation

@davidben

Copy link
Copy Markdown
Contributor

Those were temporary things we'd add and remove for our own convenience
long ago. The last few stayed around for too long as an oversight but
have since been removed. These days we have a running
BORINGSSL_API_VERSION counter which is bumped when we find it
convenient, but 2015-11-19 was quite some time ago, so just check
OPENSSL_IS_BORINGSSL.

Those were temporary things we'd add and remove for our own convenience
long ago. The last few stayed around for too long as an oversight but
have since been removed. These days we have a running
BORINGSSL_API_VERSION counter which is bumped when we find it
convenient, but 2015-11-19 was quite some time ago, so just check
OPENSSL_IS_BORINGSSL.

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@bagder

bagder commented Oct 11, 2017

Copy link
Copy Markdown
Member

Thanks!

@bagder bagder closed this in de7597f Oct 11, 2017
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants