windows: use _strdup() instead of strdup() where missing#19794
Closed
vszakats wants to merge 4 commits into
Closed
windows: use _strdup() instead of strdup() where missing#19794vszakats wants to merge 4 commits into
_strdup() instead of strdup() where missing#19794vszakats wants to merge 4 commits into
Conversation
vszakats
marked this pull request as draft
December 1, 2025 18:54
vszakats
marked this pull request as ready for review
December 1, 2025 19:38
Member
Author
|
Windows arm64 runs became super flaky today, e.g. here with this one: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To replace deprecated
strdup()CRT calls with the recommended_strdup().Refs:
https://learn.microsoft.com/cpp/c-runtime-library/reference/strdup-wcsdup
https://learn.microsoft.com/cpp/c-runtime-library/reference/strdup-wcsdup-mbsdup