Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memdebug improvements #1980

Closed
wants to merge 2 commits into from

Conversation

@bagder
Copy link
Member

commented Oct 10, 2017

I bring two changes in this set:

  1. the memdebug system now also covers send, recv and socket properly. They're logged and they're affected by the "memlimit" system that's used by the torture tests which means that by setting the correct environment variable we can make those calls return failures as well. runtests.pl -t that covers more exit paths for each test.
  2. Starting now, valgrind is used for the torture tests as well if found and not disabled. Previously, the torture tests only used the internal memory debug system which is disabled when libcurl is built with the threaded resolver! Valgrind of course detects leaks and memory problems even better and with better error reporting. Using valgrind on torture tests makes them MUCH slower so beware.
bagder added 2 commits Oct 10, 2017
... to allow them to be included in torture tests too.
note: it makes them even more slow
@bagder bagder closed this in ad164ec Oct 14, 2017
@bagder bagder deleted the bagder/memdebug-sendrecv branch Oct 14, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.