Log when SSLKEYLOGFILE is set #19814
Closed
yedayak wants to merge 1 commit into
Closed
Conversation
yedayak
force-pushed
the
sslkeylog-verbose
branch
3 times, most recently
from
941d153 to
5deb502
Compare
|
Analysis of PR #19814 at 5deb5028: Test 2090 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 48 different CI jobs (the link just goes to one of them). Generated by Testclutch |
yedayak
force-pushed
the
sslkeylog-verbose
branch
from
5deb502 to
630f56d
Compare
yedayak
changed the title
yedayak
force-pushed
the
sslkeylog-verbose
branch
from
630f56d to
5869507
Compare
vszakats
reviewed
Dec 4, 2025
bagder
reviewed
Dec 4, 2025
yedayak
force-pushed
the
sslkeylog-verbose
branch
2 times, most recently
from
805fa8d to
7304f73
Compare
Member
|
Maybe you can rebase this onto master now? |
yedayak
force-pushed
the
sslkeylog-verbose
branch
from
7304f73 to
d2c4d44
Compare
Contributor
Author
|
Rebased I wanted to add a test to this, but I'm not sure how to do it? Is there a way to test the output of |
Member
|
The |
yedayak
force-pushed
the
sslkeylog-verbose
branch
from
0a142ef to
6b6ec66
Compare
If built with LibreSSL, also warn that it only works for TLS <= 1.2 Inspired-by: Viktor Szakats
yedayak
force-pushed
the
sslkeylog-verbose
branch
from
6b6ec66 to
0b15b2c
Compare
vszakats
approved these changes
Apr 21, 2026
bagder
approved these changes
Apr 23, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also inspired by #19631 (comment)