ldap: call ldap_init() before setting the options#19830
Closed
bagder wants to merge 1 commit into
Closed
Conversation
vszakats
reviewed
Dec 4, 2025
| if(ldap_ssl) { | ||
| #ifdef HAVE_LDAP_SSL | ||
| #ifdef USE_WIN32_LDAP | ||
| /* Win32 LDAP SDK does not support insecure mode without CA! */ |
Member
There was a problem hiding this comment.
Maybe move this comment to stay above ldap_sslinit()?
It seems to be referring to the secure (3rd) option of it.
https://learn.microsoft.com/windows/win32/api/winldap/nf-winldap-ldap_sslinit
Member
Author
There was a problem hiding this comment.
In my mind the comment explains why the #ifdef is like that and the verifypeer logic is not applied to the windows part - more than the sslinit call.
Member
There was a problem hiding this comment.
It may be, yes. It may also apply somewhat to the setopt line.
The comment also reads a little ambiguous.
vszakats
approved these changes
Dec 4, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 15, 2026
Regression in 8.18.0. Reported-by: Yoshiro Yoneya Fixes curl#20927 Follow-up to 39d1976 curl#19830
This was referenced Mar 15, 2026
vszakats
added a commit
that referenced
this pull request
Mar 16, 2026
vszakats
added a commit
that referenced
this pull request
Mar 16, 2026
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Regression since curl 8.18.0. Reported-by: Yoshiro Yoneya Fixes curl#20927 Follow-up to 39d1976 curl#19830 Closes curl#20928
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
Already set after `ldap_sslinit()`/`ldap_init()` and before `ldap_ssl`-specific initialization. Follow-up to 39d1976 curl#19830 Follow-up to b41e65a Follow-up to b91421b Closes curl#20930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.