Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upcli tool: reimplement stdin buffering in -F. #1985
Conversation
monnerat
added some commits
Oct 12, 2017
| /* Check if file is "-". If so, use a callback to read OUR stdin (to | ||
| /* Mime part callbacks for stdin. */ | ||
| static size_t stdin_read(char *buffer, size_t size, size_t nitems, void *arg) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
| } | ||
| /* Shrink buffer to spare memory resources. */ | ||
| if(sip->size < sip->curpos) | ||
| sip->data = realloc(sip->data, (size_t) sip->size); |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bagder
Oct 12, 2017
Member
Even shrinking can fail so this return code must be checked and bail out if you fail.
bagder
Oct 12, 2017
Member
Even shrinking can fail so this return code must be checked and bail out if you fail.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Pushed: 665b3e4 |
monnerat
closed this
Oct 12, 2017
monnerat
deleted the
monnerat:buffer_stdin
branch
Oct 12, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bagder
Oct 12, 2017
Member
Yes, but none of my remarks were addressed?
And please use 'closes #[num]' in commit messages that close PRs (or "closes [URL]")
|
Yes, but none of my remarks were addressed? And please use 'closes #[num]' in commit messages that close PRs (or "closes [URL]") |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bagder
Oct 12, 2017
Member
oh, did I remark after it was merged perhaps? I think you need to give us slightly more time to review...
|
oh, did I remark after it was merged perhaps? I think you need to give us slightly more time to review... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
monnerat
Oct 12, 2017
Collaborator
oh, did I remark after it was merged perhaps? I think you need to give us slightly more time to review...
Yes, I think so: I've just received the mails.
Thanks for your review and I'll take your remarks in consideration. I was not expecting it but just wanted to have checks on cross-platforms :-)
Yes, I think so: I've just received the mails. Thanks for your review and I'll take your remarks in consideration. I was not expecting it but just wanted to have checks on cross-platforms :-) |
added a commit
that referenced
this pull request
Oct 12, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
monnerat
Oct 12, 2017
Collaborator
There's already a file2memory function you should use instead!
Fixed: 5650905
Fixed: 5650905 |
monnerat commentedOct 12, 2017
Dummy PR to check new code on APPVeyor/Travis CI