cli tool: reimplement stdin buffering in -F. #1985

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Collaborator

monnerat commented Oct 12, 2017

Dummy PR to check new code on APPVeyor/Travis CI

monnerat added some commits Oct 12, 2017

-/* Check if file is "-". If so, use a callback to read OUR stdin (to
+
+/* Mime part callbacks for stdin. */
+static size_t stdin_read(char *buffer, size_t size, size_t nitems, void *arg)
@bagder

bagder Oct 12, 2017

Owner

There's already a file2memory function you should use instead!

+ }
+ /* Shrink buffer to spare memory resources. */
+ if(sip->size < sip->curpos)
+ sip->data = realloc(sip->data, (size_t) sip->size);
@bagder

bagder Oct 12, 2017

Owner

Even shrinking can fail so this return code must be checked and bail out if you fail.

Collaborator

monnerat commented Oct 12, 2017

Pushed: 665b3e4

@monnerat monnerat closed this Oct 12, 2017

@monnerat monnerat deleted the monnerat:buffer_stdin branch Oct 12, 2017

Owner

bagder commented Oct 12, 2017

Yes, but none of my remarks were addressed?

And please use 'closes #[num]' in commit messages that close PRs (or "closes [URL]")

Owner

bagder commented Oct 12, 2017

oh, did I remark after it was merged perhaps? I think you need to give us slightly more time to review...

Collaborator

monnerat commented Oct 12, 2017

oh, did I remark after it was merged perhaps? I think you need to give us slightly more time to review...

Yes, I think so: I've just received the mails.

Thanks for your review and I'll take your remarks in consideration. I was not expecting it but just wanted to have checks on cross-platforms :-)

monnerat added a commit that referenced this pull request Oct 12, 2017

Collaborator

monnerat commented Oct 12, 2017

There's already a file2memory function you should use instead!

Fixed: 5650905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment