Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisescli tool: reimplement stdin buffering in -F. #1985
Conversation
monnerat
added some commits
Oct 12, 2017
bagder
requested changes
Oct 12, 2017
| /* Check if file is "-". If so, use a callback to read OUR stdin (to | ||
|
|
||
| /* Mime part callbacks for stdin. */ | ||
| static size_t stdin_read(char *buffer, size_t size, size_t nitems, void *arg) |
This comment has been minimized.
This comment has been minimized.
| } | ||
| /* Shrink buffer to spare memory resources. */ | ||
| if(sip->size < sip->curpos) | ||
| sip->data = realloc(sip->data, (size_t) sip->size); |
This comment has been minimized.
This comment has been minimized.
bagder
Oct 12, 2017
Member
Even shrinking can fail so this return code must be checked and bail out if you fail.
This comment has been minimized.
This comment has been minimized.
|
Pushed: 665b3e4 |
monnerat
closed this
Oct 12, 2017
monnerat
deleted the
monnerat:buffer_stdin
branch
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
|
Yes, but none of my remarks were addressed? And please use 'closes #[num]' in commit messages that close PRs (or "closes [URL]") |
This comment has been minimized.
This comment has been minimized.
|
oh, did I remark after it was merged perhaps? I think you need to give us slightly more time to review... |
This comment has been minimized.
This comment has been minimized.
Yes, I think so: I've just received the mails. Thanks for your review and I'll take your remarks in consideration. I was not expecting it but just wanted to have checks on cross-platforms :-) |
monnerat
added a commit
that referenced
this pull request
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
Fixed: 5650905 |
monnerat commentedOct 12, 2017
Dummy PR to check new code on APPVeyor/Travis CI