hsts: use one malloc instead of two per entry - #19861
Closed
bagder wants to merge 1 commit into
Closed
Conversation
bagder
marked this pull request as ready for review
December 7, 2025 11:28
Member
Author
|
augment review |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR optimizes memory allocation for HSTS entries by using a flexible array member pattern instead of separate allocations for the structure and hostname string. This reduces allocation overhead from two malloc calls to one per entry.
- Converted
stsentrystructure from using a separateconst char *hostpointer to an inline flexible array memberchar host[1] - Simplified memory management by consolidating allocation and deallocation into single operations
- Removed unnecessary const-casting since the host field is now mutable by design
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/hsts.h | Changed stsentry structure to use flexible array member char host[1] instead of const char *host pointer |
| lib/hsts.c | Updated allocation to single calloc with extra space for hostname, simplified deallocation to macro, removed CURL_UNCONST cast |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.