http: return OOM errors from hsts properly #19862
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Curl_hsts_parse() fails with out of memory, return it to parent.
Member
Author
|
augment review |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR fixes error handling in HTTP header parsing to properly propagate out-of-memory (OOM) errors from HSTS header parsing. When Curl_hsts_parse() encounters a memory allocation failure, the error is now returned to the caller instead of being logged and ignored. This aligns with the existing error handling pattern used for other authentication parsers (NTLM, Digest) in the same file.
- Adds early return for
CURLE_OUT_OF_MEMORYerrors fromCurl_hsts_parse() - Preserves existing behavior for non-OOM parsing errors (logged but not fatal)
- Follows established codebase pattern for critical error propagation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Curl_hsts_parse() fails with out of memory, return it to parent.