hostcheck: fail wildcard match if host starts with a dot #19869
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A hostname cannot start with a dot when DNS is used, but there are other ways. Amend unit test 1397
Member
Author
|
augment review |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR enhances hostname validation in wildcard certificate matching by explicitly rejecting hostnames that start with a dot. While such hostnames are invalid in DNS, they could potentially be used in other contexts, so this change adds an extra security measure to the wildcard matching logic.
- Adds explicit check to reject hostnames starting with a dot in wildcard pattern matching
- Updates the comment to reflect the new validation rule
- Adds test cases to verify the new behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/vtls/hostcheck.c | Adds validation to reject hostnames starting with a dot in wildcard certificate matching, updating the check at line 96 and its associated comment |
| tests/unit/unit1397.c | Adds two test cases at the beginning of the test array to verify that hostnames starting with a dot are rejected while normal hostnames continue to match correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hostname cannot start with a dot when DNS is used, but there are other ways.
Amend unit test 1397