New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test651: curl_formadd with huge COPYCONTENTS #1988

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@bagder
Member

bagder commented Oct 12, 2017

No description provided.

bagder added some commits Oct 12, 2017

fixup: modify test case
... shows a bug after the first 16K on 7.56.0

Code-by: Jeroen Ooms
@bagder

This comment has been minimized.

Member

bagder commented Oct 12, 2017

ping @monnerat, we got an interesting regression reported by @jeroen that I just managed to reproduce with this test case and the amended commit. It shows that the output data is somehow repeating after the first 16K!

@bagder

This comment has been minimized.

Member

bagder commented Oct 12, 2017

I think that fixes it, just needs to run through the CI to make sure nothing breaks while I run some more tests locally as well.

@monnerat

Oups, my bad !
16K is the read buffer size and we had no test with more memory data... good catch.
I completely agree with the fix.

@bagder bagder closed this in 5f9e2ca Oct 13, 2017

@bagder bagder deleted the bagder/test-huge-COPYCONTENTS branch Oct 13, 2017

@jeroen

This comment has been minimized.

Contributor

jeroen commented Oct 13, 2017

Thanks for the quick fix! Are there plans for a patch release soon, or should i better cherry pick the patch into my deployment?

@bagder

This comment has been minimized.

Member

bagder commented Oct 13, 2017

I have had discussions with some peeps about about a possible patch release but not properly (ie not on the mailing list) and nothing has been decided yet. And even if we will decide to make one, it will be at a set date at least one week into the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment