test651: curl_formadd with huge COPYCONTENTS#1988
Closed
Conversation
... shows a bug after the first 16K on 7.56.0 Code-by: Jeroen Ooms
Member
Author
... as verified by test 651
Member
Author
|
I think that fixes it, just needs to run through the CI to make sure nothing breaks while I run some more tests locally as well. |
monnerat
approved these changes
Oct 12, 2017
Contributor
monnerat
left a comment
monnerat
left a comment
There was a problem hiding this comment.
Oups, my bad !
16K is the read buffer size and we had no test with more memory data... good catch.
I completely agree with the fix.
Contributor
|
Thanks for the quick fix! Are there plans for a patch release soon, or should i better cherry pick the patch into my deployment? |
Member
Author
|
I have had discussions with some peeps about about a possible patch release but not properly (ie not on the mailing list) and nothing has been decided yet. And even if we will decide to make one, it will be at a set date at least one week into the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.