headers: add length argument to Curl_headers_push() - #19886
Closed
bagder wants to merge 2 commits into
Closed
Conversation
bagder
marked this pull request as ready for review
December 9, 2025 09:05
- the length is already known by parent functions - avoids strlen() calls - avoids strchr() calls for trimming off newline characters
Member
Author
|
augment review |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR optimizes the Curl_headers_push() function by adding a length parameter to eliminate redundant string operations. The length is already known by calling functions, so passing it directly avoids expensive strlen() calls and strchr() searches for line ending detection.
Key changes:
- Added
size_t hlenparameter toCurl_headers_push()function signature - Replaced
strchr()-based newline detection with direct index-based trimming - Updated call sites to pass the length value (from
curl_msnprintfreturn value and existing buffer length)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/headers.h | Updated function declaration to include the new hlen parameter |
| lib/headers.c | Modified implementation to accept length parameter and replaced newline detection logic with more efficient character-by-character trimming from the end |
| lib/http2.c | Updated call site to capture curl_msnprintf return value and pass it as the length parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bagder
force-pushed
the
bagder/push-len
branch
from
December 9, 2025 09:27
ef076d4 to
c41d58b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.