Skip to content

build: set -Wno-format-signedness - #19907

Closed
vszakats wants to merge 3 commits into
curl:masterfrom
vszakats:nosigncheck
Closed

build: set -Wno-format-signedness#19907
vszakats wants to merge 3 commits into
curl:masterfrom
vszakats:nosigncheck

Conversation

@vszakats

@vszakats vszakats commented Dec 9, 2025

Copy link
Copy Markdown
Member

Explicitly disable these warnings to allow using -Weverything.

There are around 600 of them across the codebase.

Silencing them has some drawbacks:

  • enums (CURLcode mostly) would have to be cast to int to avoid
    different signedness depending on C compiler.
    (llvm/gcc: unsigned, MSVC/clang-cl: signed by default)
  • hex masks need casts to unsigned to avoid the warning.
  • fixing remaining warnings is annoying without fixing the above.
  • without fixing all warnings the option cannot be enabled, to keep
    the codebase warning free.

Ref: #18343 (silenced all warnings, but without the enum cast)
Follow-up to 92f215f #18477

@github-actions github-actions Bot added the build label Dec 9, 2025
@vszakats vszakats closed this in bd19433 Dec 9, 2025
@vszakats
vszakats deleted the nosigncheck branch December 9, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant