Skip to content

Conversation

@icing
Copy link
Contributor

@icing icing commented Dec 11, 2025

With either /usr/sbin/sshd found or configured via --with-test-sshd=path add tests for SCP down- and uploads, insecure, with known hosts or not, with authorized user key or unauthorized one.

Added SFTP configuration and test cases.

@github-actions github-actions bot added the tests label Dec 11, 2025
@github-actions github-actions bot added the CI Continuous Integration label Dec 11, 2025
@curl curl deleted a comment from testclutch Dec 11, 2025
With either /usr/sbin/sshd found or configured via --with-test-sshd=path
add tests for SCP down- and uploads, insecure, with known hosts or not,
with authorized user key or unauthorized one.

Working now with libssh and libssh2, using a hashed known_hosts file.
@icing
Copy link
Contributor Author

icing commented Dec 11, 2025

@vszakats while we always seem to have sshd in CI, most pytest runs are builds without libssh or libssh2.

I found one libssh working in linux/CM address-sanitizer, but not much more. At least one more pytest with libssh2 would be good. Since you have the best overview, can you take care of that once we merge this one?

@vszakats
Copy link
Member

@vszakats while we always seem to have sshd in CI, most pytest runs are builds without libssh or libssh2.

I found one libssh working in linux/CM address-sanitizer, but not much more. At least one more pytest with libssh2 would be good. Since you have the best overview, can you take care of that once we merge this one?

I can, yes, they could indeed be better covered in CI, esp. on Linux.

[ https://testclutch.curl.se/static/reports/feature-matrix.html ]

@icing icing requested a review from bagder December 12, 2025 10:19
@bagder bagder closed this in eb39fee Dec 12, 2025
vszakats added a commit that referenced this pull request Dec 12, 2025
To run more pytest sshd tests, and for more static analysis.

Also:
- drop redundant option from `openssl libssh2 ...` config.
- GHA/linux: enable pytest in the LTO job (to test libssh2).
- avoid both with local builds of OpenSSL-forks, due to crypto lib
  mixups causing a mixture of build error, crashes, test failures.

Follow-up to eb39fee #19934

Closes #19943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration tests

Development

Successfully merging this pull request may close these issues.

3 participants