tool_urlglob: support globs as long as config line lengths #19960
Conversation
libcurl supports up to 8MB string inputs, the config file accepts up to 10MB line lengths. It did not make sense to limit the globs to a maximum of one megabyte.
|
augment review |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR refactors the maximum URL glob buffer size limit to align with the config file line length limit. The MAX_CONFIG_LINE_LENGTH constant (10MB) is moved from tool_parsecfg.c to the shared header tool_cfgable.h, allowing tool_urlglob.c to use the same limit instead of its previous hardcoded 1MB limit.
Key changes:
- Moves
MAX_CONFIG_LINE_LENGTHdefinition to a shared header for reusability - Updates URL glob buffer initialization to support config line length-sized URLs (10MB instead of 1MB)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tool_cfgable.h | Adds the MAX_CONFIG_LINE_LENGTH constant definition (10MB) for shared use across source files |
| src/tool_parsecfg.c | Removes the local MAX_CONFIG_LINE_LENGTH definition, now using the shared constant from tool_cfgable.h |
| src/tool_urlglob.c | Changes glob buffer initialization from hardcoded 1MB limit to use MAX_CONFIG_LINE_LENGTH (10MB) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #19960 at cab4ee76: Test 2029 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
2 participants
libcurl supports up to 8MB string inputs, the config file accepts up to 10MB line lengths. It did not make sense to limit the globs to a maximum of one megabyte.