runtests: improve XML prolog check, enable -w permanently, fix two tests#19970
Closed
vszakats wants to merge 7 commits into
Closed
runtests: improve XML prolog check, enable -w permanently, fix two tests#19970vszakats wants to merge 7 commits into
-w permanently, fix two tests#19970vszakats wants to merge 7 commits into
Conversation
This reverts commit 2202303.
vszakats
changed the title
-w permanently
vszakats
changed the title
-w permanently-w permanently, fix two tests
vszakats
changed the title
-w permanently, fix two tests-w permanently, fix two tests
mkauf
pushed a commit
to mkauf/curl
that referenced
this pull request
Dec 15, 2025
Address issues listed in curl#19770: - allow for ngttpx to successfully shut down on last attempt that might extend beyond the finish timestamp - timeline checks: allos `time_starttransfer` to appear anywhere in the timeline as a slow client might seen response data before setting the other counters - dump logs on test_05_02 as it was not reproduced locally Fixes curl#19970 Closes curl#19783
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To really verify the presence of the XML prolog, also in CI.
loadtesttochecktest.(load did a soft error, silently skipping the test instead of failing)
-wfunctionality permanently for all test targets,drop the option. It has no measurable performance impact.
Follow-up to f0d277c
Follow-up to b5ea073 #19946
Follow-up to 904e7ec #19347
-wpermanently and drop the option.