Skip to content

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Dec 14, 2025

To really verify the presence of the XML prolog, also in CI.

  • move the prolog check from loadtest to checktest.
    (load did a soft error, silently skipping the test instead of failing)
  • runtests: enable -w functionality permanently for all test targets,
    drop the option. It has no measurable performance impact.
  • test 798, 1665: add XML prolog.
    Follow-up to f0d277c

Follow-up to b5ea073 #19946
Follow-up to 904e7ec #19347


  • consider enabling -w permanently and drop the option.

@vszakats vszakats added the tests label Dec 14, 2025
@vszakats vszakats marked this pull request as draft December 14, 2025 08:46
@github-actions github-actions bot added the CI Continuous Integration label Dec 14, 2025
This reverts commit 2202303.
@vszakats vszakats marked this pull request as ready for review December 14, 2025 09:25
@vszakats vszakats changed the title runtests: check for XML prolog in CI runtests: check for XML prolog in CI, enable -w permanently Dec 14, 2025
@vszakats vszakats changed the title runtests: check for XML prolog in CI, enable -w permanently runtests: check for XML prolog in CI, enable -w permanently, fix two tests Dec 14, 2025
@vszakats vszakats changed the title runtests: check for XML prolog in CI, enable -w permanently, fix two tests runtests: improve XML prolog check, enable -w permanently, fix two tests Dec 14, 2025
@vszakats vszakats closed this in 187e219 Dec 14, 2025
@vszakats vszakats deleted the stillxml branch December 14, 2025 11:27
mkauf pushed a commit to mkauf/curl that referenced this pull request Dec 15, 2025
Address issues listed in curl#19770:
- allow for ngttpx to successfully shut down on last attempt that might
  extend beyond the finish timestamp
- timeline checks: allos `time_starttransfer` to appear anywhere in
  the timeline as a slow client might seen response data before setting
  the other counters
- dump logs on test_05_02 as it was not reproduced locally

Fixes curl#19970
Closes curl#19783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration tests

Development

Successfully merging this pull request may close these issues.

1 participant