cookie. return proper error on OOM#19992
Closed
bagder wants to merge 1 commit into
Closed
Conversation
Follow-up to a78a07d
Member
Author
|
augment review |
bagder
marked this pull request as ready for review
December 16, 2025 08:12
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR fixes an error handling issue in the Curl_cookie_add function where an out-of-memory (OOM) condition was not properly reported. When Curl_memdup fails to allocate memory for cloning a cookie structure from stack to heap, the function now correctly sets result = CURLE_OUT_OF_MEMORY before jumping to the error handling path.
Key changes:
- Added proper error code assignment (
CURLE_OUT_OF_MEMORY) when memory allocation fails during cookie cloning
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to a78a07d