Skip to content

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Dec 16, 2025

Define CERT_NAME_SEARCH_ALL_NAMES_FLAG macro if missing.
To allow using a runtime branch regardless of build-time SDK version,
when running on Windows 8+.

In practice it enables this branch for builds using mingw-w64 v3, and
MSVC with Windows SDK <8.

Also reducing build variations.

Follow-up to 29e40a6 #4761 #3711
Follow-up to 8996300 #1325
Follow-up to 172b2be #264 (comment)

@github-actions github-actions bot added TLS Windows Windows-specific labels Dec 16, 2025
@vszakats vszakats added the build label Dec 16, 2025
@vszakats vszakats changed the title schannel: enable Win8 CERT_NAME_SEARCH_ALL_NAMES_FLAG with old SDKs schannel: use Win8 CERT_NAME_SEARCH_ALL_NAMES_FLAG with old SDKs Dec 16, 2025
@vszakats vszakats requested a review from Copilot December 16, 2025 16:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the use of Windows 8+ certificate name search functionality at runtime regardless of the SDK version used at build time. This is achieved by defining the CERT_NAME_SEARCH_ALL_NAMES_FLAG macro when it's not provided by the SDK, allowing older build environments (mingw-w64 v3 and MSVC with Windows SDK <10) to take advantage of this feature when running on Windows 8 or later.

Key changes:

  • Moves the CERT_NAME_SEARCH_ALL_NAMES_FLAG check inside the runtime Windows 8 compatibility check
  • Defines the flag locally when the SDK doesn't provide it, enabling runtime branching
  • Removes unnecessary (void) casts that were previously needed to suppress unused variable warnings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vszakats vszakats closed this in 8dadff9 Dec 16, 2025
@vszakats vszakats deleted the CERT_NAME_SEARCH_ALL_NAMES_FLAG branch December 16, 2025 19:41
@vszakats
Copy link
Member Author

Thanks @jay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build TLS Windows Windows-specific

Development

Successfully merging this pull request may close these issues.

2 participants