Repository navigation
Conversation
CERT_NAME_SEARCH_ALL_NAMES_FLAG with old SDKsCERT_NAME_SEARCH_ALL_NAMES_FLAG with old SDKs
There was a problem hiding this comment.
Pull request overview
This PR enables the use of Windows 8+ certificate name search functionality at runtime regardless of the SDK version used at build time. This is achieved by defining the CERT_NAME_SEARCH_ALL_NAMES_FLAG macro when it's not provided by the SDK, allowing older build environments (mingw-w64 v3 and MSVC with Windows SDK <10) to take advantage of this feature when running on Windows 8 or later.
Key changes:
- Moves the
CERT_NAME_SEARCH_ALL_NAMES_FLAGcheck inside the runtime Windows 8 compatibility check - Defines the flag locally when the SDK doesn't provide it, enabling runtime branching
- Removes unnecessary
(void)casts that were previously needed to suppress unused variable warnings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jay
approved these changes
Dec 16, 2025
Member
Author
|
Thanks @jay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
CERT_NAME_SEARCH_ALL_NAMES_FLAGmacro if missing.To allow using a runtime branch regardless of build-time SDK version,
when running on Windows 8+.
In practice it enables this branch for builds using mingw-w64 v3, and
MSVC with Windows SDK <8.
Also reducing build variations.
Follow-up to 29e40a6 #4761 #3711
Follow-up to 8996300 #1325
Follow-up to 172b2be #264 (comment)