badwords: catch and fix threading-related words #20001
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR standardizes threading-related terminology across the codebase by adding badwords.txt patterns to enforce consistent hyphenation and applying those fixes throughout the code. The changes ensure that "thread-safe", "thread-unsafe", and "multi-thread" are consistently hyphenated across all documentation, comments, and examples.
Key Changes:
- Added three regex patterns to
.github/scripts/badwords.txtto catch unhyphenated threading terminology - Fixed 40+ instances of unhyphenated threading terms across source files, headers, and documentation
- Synchronized newline formatting between
threaded.candthreaded-ssl.cexample files - Updated build configuration to reflect the renamed example file from
multithreadtothreaded
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/scripts/badwords.txt | Added regex patterns to enforce hyphenation in "thread-safe", "thread-unsafe", and "multi-thread" |
| tests/server/util.c | Fixed "multithreaded" → "multi-threaded" |
| m4/curl-functions.m4 | Fixed "threadsafe" → "thread-safe" in multiple locations (comments and messages) |
| lib/vtls/gtls.c | Fixed "thread safe" → "thread-safe" in comment |
| lib/memdebug.c | Fixed "multithreaded" → "multi-threaded" in comment |
| lib/http_ntlm.c | Fixed "thread safe" → "thread-safe" in comment |
| lib/hostip4.c | Fixed "threadsafe" → "thread-safe" in multiple comments |
| lib/hostip.h | Fixed "threadsafe" → "thread-safe" in comment |
| lib/config-os400.h | Fixed "threadsafe" → "thread-safe" and "threadsafeness" → "thread-safeness" |
| lib/amigaos.c | Fixed "thread safe" → "thread-safe" in comments |
| include/curl/easy.h | Fixed "multithreaded" → "multi-threaded" in comment |
| docs/libcurl/opts/CURLOPT_DNS_USE_GLOBAL_CACHE.md | Fixed "thread unsafe" → "thread-unsafe" in example comment |
| docs/libcurl/libcurl.md | Fixed "thread safe" → "thread-safe" in multiple locations |
| docs/libcurl/libcurl-tutorial.md | Fixed "thread safe" → "thread-safe" |
| docs/libcurl/libcurl-thread.md | Fixed "thread safe" and "thread implementations" → "thread-safe" in multiple locations |
| docs/libcurl/curl_global_trace.md | Fixed "thread unsafe" → "thread-unsafe" |
| docs/libcurl/curl_global_init.md | Fixed "thread unsafe" → "thread-unsafe" |
| docs/libcurl/curl_global_cleanup.md | Fixed "thread unsafe" → "thread-unsafe" |
| docs/examples/threaded.c | Added blank lines for consistent formatting with threaded-ssl.c |
| docs/examples/threaded-ssl.c | Fixed "thread safe" → "thread-safe" and added blank lines for formatting consistency |
| docs/examples/smooth-gtk-thread.c | Fixed "multi threaded" → "multi-threaded" in description |
| docs/examples/http2-upload.c | Fixed "thread safe" → "thread-safe" in comment |
| docs/examples/Makefile.inc | Updated reference from "multithread.c" to "threaded.c" |
| docs/examples/.gitignore | Updated reference from "multithread" to "threaded" |
| RELEASE-NOTES | Updated reference from "multithread" to "threaded" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
vszakats
added a commit
that referenced
this pull request
Dec 16, 2025
After applying a recent fix made to `threaded.c` (formerly `multithread.c`) to `threaded-ssl.c`, syncing and updating comments, the two examples turned out to be identical except their test URLs. Delete one of them to avoid duplication. Also: - examples/threaded: scope a variable. - examples/threaded: merge comments from its deleted sibling. Follow-up to 61273f5 #20001 Follow-up to 971e8d6 #19526 #19524 Closes #20002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: