curlx: use curl alloc in curlx_win32_stat() (Windows) - #20043
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
vszakats
marked this pull request as draft
December 20, 2025 01:35
vszakats
marked this pull request as ready for review
December 20, 2025 01:36
vszakats
changed the title
curlx_win32_stat() (Windows)curlx_win32_stat() (Windows)
There was a problem hiding this comment.
Pull request overview
This PR updates curlx_win32_stat() to use curl's standard allocation functions instead of conditional allocation macros. The change replaces the internal fn_convert_UTF8_to_wchar() helper with the public curlx_convert_UTF8_to_wchar() API, and replaces the CURLX_FREE() macro with a direct curlx_free() call.
Key Changes
- Switches from internal helper function to public API for UTF-8 to wchar conversion
- Replaces conditional allocation macro with direct curlx_free() call
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's safe because we do not call
curlx_win32_stat()from memdebug.c.