tool_urlglob: constify an argument #20045
Closed
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: add argument names to prototypes.
There was a problem hiding this comment.
Pull request overview
This PR improves the API design of the tool_urlglob module by adding const correctness to the url parameter and enhancing code readability by adding parameter names to function prototypes.
- Added
constqualifier to theurlparameter inglob_urlfunction - Added descriptive parameter names to all function prototypes in the header file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tool_urlglob.h | Added parameter names to all function declarations and added const qualifier to the url parameter in glob_url declaration |
| src/tool_urlglob.c | Added const qualifier to the url parameter in glob_url implementation to match the header declaration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: add argument names to prototypes.