test96: fix to accept non-unity memdump content with MSVC #20064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen in msvc, CM x64-windows openssl +examples job: ``` --- log/8/check-expected 2025-12-21 10:20:56.062527200 +0000 +++ log/8/check-generated 2025-12-21 10:20:56.062527200 +0000 @@ -1,6 +1,6 @@ -MEM tool_cfgable.c[LF] -MEM tool_paramhlp.c[LF] -MEM tool_cfgable.c[LF] -MEM tool_cfgable.c[LF] -MEM tool_cfgable.c[LF] -MEM tool_cfgable.c[LF] +MEM D:\a\curl\curl\src\tool_cfgable.c[LF] +MEM D:\a\curl\curl\src\tool_paramhlp.c[LF] +MEM D:\a\curl\curl\src\tool_cfgable.c[LF] +MEM D:\a\curl\curl\src\tool_cfgable.c[LF] +MEM D:\a\curl\curl\src\tool_cfgable.c[LF] +MEM D:\a\curl\curl\src\tool_cfgable.c[LF] ``` Ref: https://github.com/curl/curl/actions/runs/20408366058/job/58641468316?pr=20061#step:13:303
This reverts commit 2da09c6.
vszakats
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In unity builds the source filename (via
__FILE__) has no path (oruses slashes?), while in non-unity ones it does contain backslashes
on Windows, with MSVC. Fix the test to recognize backslashes in the
stripfileregexp.Seen in MSVC jobs in CI:
Ref: https://github.com/curl/curl/actions/runs/20408366058/job/58641468316?pr=20061#step:13:303
Ref: https://github.com/curl/curl/actions/runs/20408522070/job/58641826216?pr=20064#step:13:298