Skip to content

vquic: initialize new callback in nghttp3 1.14.0+ #20077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vszakats wants to merge 2 commits into from
Closed

vquic: initialize new callback in nghttp3 1.14.0+ #20077

vszakats wants to merge 2 commits into from

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Dec 23, 2025 •
edited
Loading

Fixing (seen in curl-for-win production build):

lib/vquic/curl_ngtcp2.c:1257:1: error: missing field 'recv_settings2' initializer [-Werror,-Wmissing-field-initializers]
 1257 | };
      | ^
1 error generated.

Ref: https://ci.appveyor.com/project/curlorg/curl-for-win/builds/53281785#L6752
Ref: https://github.com/curl/curl/actions/runs/20459295003/job/58788229134#step:3:5513

Also:

  • Mark previous callback deprecated.
  • Document ngtcp2, nghttp3 versions for callback entry feature guards.

Refs:
https://github.com/ngtcp2/nghttp3/releases/tag/v1.14.0
ngtcp2/nghttp3#432
ngtcp2/nghttp3@1616ab8

@vszakats vszakats added build HTTP/3 h3 or quic related labels Dec 23, 2025
bagder
bagder reviewed Dec 23, 2025
View reviewed changes
lib/vquic/curl_ngtcp2.c Outdated
NULL, /* end_origin */
NULL, /* rand */
#endif
#ifdef NGHTTP3_CALLBACKS_V3
Copy link
Member

@bagder bagder Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a comment that this is for 1.14.0+ ?

vszakats added a commit to curl/curl-for-win that referenced this pull request Dec 23, 2025
@vszakats
curl: patch warning for nghttp3 1.14.0+
c3829f0 
curl/curl#20077
@vszakats vszakats closed this in 17628b1 Dec 23, 2025
@vszakats vszakats deleted the nghttp3_1140 branch December 23, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

build HTTP/3 h3 or quic related

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vszakats @bagder