curl_ntlm_core: fix DES_* symbols for some wolfSSL builds #20083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent wolfSSL with OPENSSL_COEXIST enabled does not provide the DES_* symbols, so we do. Reported-by: Daniel Pouzzner
There was a problem hiding this comment.
Pull request overview
This PR fixes missing DES_ENCRYPT and DES_DECRYPT symbols for wolfSSL builds when OPENSSL_COEXIST mode is enabled in wolfSSL version 5.7.6 and later.
Key Changes:
- Added
<wolfssl/version.h>include to access version macros - Added version-conditional defines for DES_ENCRYPT and DES_DECRYPT that map to WC_DES_ENCRYPT and WC_DES_DECRYPT for wolfSSL >= 5.7.6
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Analysis of PR #20083 at d263bbc6: Test 271 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 12 different CI jobs (the link just goes to one of them). Generated by Testclutch |
douzzer
reviewed
Dec 23, 2025
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
LGTM
[curl-master-with-wolfssl-coexist] [1 of 1] [d36bfabe18]
autoreconf curl d263bbc666... real 0m9.759s user 0m8.384s sys 0m0.439s
autogen.sh d36bfabe18... real 0m8.507s user 0m7.148s sys 0m0.425s
configure... real 0m7.659s user 0m4.764s sys 0m3.397s
build... real 0m5.301s user 0m54.360s sys 0m3.645s
configure curl... real 0m9.771s user 0m5.764s sys 0m4.428s
build curl... real 0m4.358s user 1m25.954s sys 0m20.799s
test curl... OK.
scenario started 2025-12-23T22:29:51.529516Z, real elapsed 0m45.730204s
curl-master-with-wolfssl-coexist OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent wolfSSL with OPENSSL_COEXIST enabled does not provide the DES_* symbols, so we do.
Reported-by: Daniel Pouzzner