tool_getparam: simplify the --rate parser#20119
Closed
bagder wants to merge 2 commits into
Closed
Conversation
Avoids a memcpy()
There was a problem hiding this comment.
Pull request overview
This PR refactors the --rate parameter parser in set_rate() to simplify the parsing logic and eliminate an unnecessary memory copy operation. The changes replace a two-step approach (using strchr() to find the delimiter, then memcpy() to extract the number) with direct pointer-based parsing using curlx_str_number() and curlx_str_single().
- Eliminates intermediate buffer allocation and
memcpy()call - Changes
denominatortype fromlongtocurl_off_tfor consistency with parsing functions - Streamlines the parsing flow by using pointer advancement built into the parsing functions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids a memcpy()