tool_paramhlp: remove a malloc+free from proto2num() #20120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR optimizes the proto2num() function by replacing a dynamically allocated protoset array with a stack-allocated one, eliminating a malloc/free pair. The change introduces a compile-time maximum protocol count (MAX_PROTOS) and uses a debug assertion to enforce this limit.
Key changes:
- Introduced
MAX_PROTOSconstant (set to 30) to define the maximum number of protocols - Replaced dynamic allocation of
protosetwith stack allocation using the new constant - Removed the corresponding
curlx_free()call and allocation failure check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bagder
force-pushed
the
bagder/proto2num-less-alloc
branch
from
0660d1b to
caf8d44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.