openssl: stop checking for OPENSSL_NO_SHA* macros
#20130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
OPENSSL_NO_SHA256OPENSSL_NO_SHA*
vszakats
changed the title
OPENSSL_NO_SHA*OPENSSL_NO_SHA* macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros have been deleted upstream and never defined in OpenSSL 1.1.0+:
openssl/openssl@474e469
BoringSSL deleted the last internals uses in 2014:
google/boringssl@457112e
LibreSSL refers to them internally and in two public headers, but never
set them via
openssl/opensslfeatures.h/openssl/opensslconf.h.Follow-up to 69c89bf #18330
https://github.com/curl/curl/pull/20130/files?w=1
opensslfeatures.h(exceptOPENSSL_NO_SHA0that's permanently defined since libressl/openbsd@3a95df6 2015-09-13). Ref: libressl/openbsd@adea791