tool_paramhlp: simplify number parsing - #20134
Closed
bagder wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to simplify number parsing in tool_paramhlp.c by removing the getnum helper function and inlining its logic directly into str2num and oct2nummax. However, the refactoring introduces critical bugs.
- Removed the
getnumhelper function - Inlined number parsing logic into
str2numandoct2nummax - Updated
str2unumto callstr2numdirectly
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.