inet_ntop: avoid the strlen()#20139
Closed
bagder wants to merge 1 commit into
Closed
Conversation
Also, skip adding the terminating null that is not used.
There was a problem hiding this comment.
Pull request overview
This PR optimizes the inet_ntop6 function by eliminating an unnecessary strlen() call and removing the redundant null terminator that was being added to the temporary buffer. The optimization leverages pointer arithmetic that is already available from the string construction process.
Key changes:
- Removed the null terminator assignment to the temporary buffer since
curlx_strcopyhandles null termination - Updated overflow check from
>to>=to correctly validate buffer space requirements - Replaced
strlen(tmp)withtp - tmpto use the already-computed string length
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, skip adding the terminating null that is not used.