mqtt: return error when a too large packet is decoded#20148
Closed
bagder wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances error handling in the MQTT protocol implementation by modifying the mqtt_decode_len function to properly detect and report when a packet's variable-length encoding exceeds the MQTT specification's 4-byte limit. The function signature is changed from returning the decoded length directly to returning an error code, with the length passed via an output parameter.
Key changes:
- Refactored
mqtt_decode_lento return an error code (0 for success, non-zero for error) instead of the decoded length value - Added validation to reject packets that attempt to use more than 4 bytes for length encoding
- Updated the call site to properly handle the new error return value
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.