Skip to content

h2+h3: align stream close handling#20207

Closed
icing wants to merge 1 commit intocurl:masterfrom
icing:h2-h3-close-handling
Closed

h2+h3: align stream close handling#20207
icing wants to merge 1 commit intocurl:masterfrom
icing:h2-h3-close-handling

Conversation

@icing
Copy link
Contributor

@icing icing commented Jan 7, 2026

For HTTP/2, add error code description to close failures.

For HTTP/3, add special handling like in HTTP/2 when streams have been rejected or an error comes during the response body and we are not interested in the body.

@icing icing requested a review from bagder January 7, 2026 14:30
vszakats added a commit that referenced this pull request Jan 7, 2026
For `PRI*` printf masks for fixed-size C99 types.

Also:
- add simple fallback for `PRIu32`, `PRIx32`, if `inttypes.h` is
  missing.

Cherry-picked from #20200
Ref: #20207
Follow-up to 4701a6d #19695
Ref: 60359ad #12275
Closes #20208
@icing icing added the feature-window A merge of this requires an open feature window label Jan 8, 2026
@icing
Copy link
Contributor Author

icing commented Jan 8, 2026

Since this is some behavioural change, let's delay merging to the feature window.

@icing icing added the HTTP label Jan 8, 2026
For HTTP/2, add error code description to close failures.

For HTTP/3, add special handling like in HTTP/2 when streams
have been rejected or an error comes during the response body
and we are not interested in the body.
@icing icing force-pushed the h2-h3-close-handling branch from e88b541 to 02ba835 Compare January 20, 2026 09:46
@icing icing requested review from bagder and removed request for bagder January 20, 2026 09:50
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready for merge?

@icing
Copy link
Contributor Author

icing commented Jan 28, 2026

Think so, yes.

@bagder bagder closed this in 0f042ef Jan 28, 2026
dkarpov1970 pushed a commit to dkarpov1970/curl that referenced this pull request Mar 5, 2026
For HTTP/2, add error code description to close failures.

For HTTP/3, add special handling like in HTTP/2 when streams
have been rejected or an error comes during the response body
and we are not interested in the body.

Closes curl#20207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-window A merge of this requires an open feature window HTTP

Development

Successfully merging this pull request may close these issues.

2 participants