Skip to content

/curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl_timeleft: change return type to timediff_t #2021

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

commented Oct 26, 2017

returning 'time_t' was problematic when that type is unsigned and we
check values less than zero to detect "already expired" on several
places in the code.
@bagder
Curl_timeleft: change return type to timediff_t
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
6c53e29 
returning 'time_t' was problematic when that type is unsigned and we
check values less than zero to detect "already expired" on several
places in the code.
@bagder bagder force-pushed the bagder/timeleft-timediff_t branch from f16b37a to 6c53e29 Oct 27, 2017
@bagder bagder closed this in 0d85eed Oct 28, 2017
@bagder bagder deleted the bagder/timeleft-timediff_t branch Oct 29, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bagder
You can’t perform that action at this time.