Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCurl_timeleft: change return type to timediff_t #2021
Conversation
bagder
force-pushed the
bagder/timeleft-timediff_t
branch
from
f16b37a
to
6c53e29
Oct 27, 2017
bagder
closed this
in
0d85eed
Oct 28, 2017
bagder
deleted the
bagder/timeleft-timediff_t
branch
Oct 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bagder commentedOct 26, 2017
returning 'time_t' was problematic when that type is unsigned and we
check values less than zero to detect "already expired" on several
places in the code.