cmake: reference OpenSSL and ZLIB imported targets only when enabled - #20217
Closed
JoshuaVandaele wants to merge 1 commit into
Closed
cmake: reference OpenSSL and ZLIB imported targets only when enabled#20217JoshuaVandaele wants to merge 1 commit into
JoshuaVandaele wants to merge 1 commit into
Conversation
JoshuaVandaele
force-pushed
the
pushback-fix
branch
3 times, most recently
from
January 8, 2026 00:29
f537f89 to
baf018c
Compare
vszakats
reviewed
Jan 9, 2026
JoshuaVandaele
force-pushed
the
pushback-fix
branch
from
January 9, 2026 15:17
baf018c to
40c0c18
Compare
vszakats
reviewed
Jan 9, 2026
This otherwise broke building on a parent with a static library which is available but disabled (e.g. CURL_ZLIB is set to OFF but ZLIB::ZLIB exists)
JoshuaVandaele
force-pushed
the
pushback-fix
branch
from
January 9, 2026 15:30
40c0c18 to
22721cd
Compare
vszakats
changed the title
Member
|
Thank you @JoshuaVandaele, merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This otherwise broke building on a parent with a static library which is available but disabled (e.g. CURL_ZLIB is set to OFF but ZLIB::ZLIB exists)