mprintf: drop old sprintf fallback #20218
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. No modern systems lack snprintf() 2. If there actually exist any such systems, they get to manage without floating point output.
There was a problem hiding this comment.
Pull request overview
This PR removes the unsafe sprintf fallback for floating-point formatting in systems that lack snprintf() support. The rationale is that no modern systems lack snprintf(), and if any such legacy systems exist, they will simply not support floating-point output rather than using the unsafe sprintf function.
Key Changes
- Removed the old
sprintffallback that was used for float/double formatting whenHAVE_SNPRINTFis not defined - Replaced it with code that sets an empty string, effectively disabling float/double output on such systems
- Added a comment explaining that float and double outputs do not work without snprintf support
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No modern systems lack snprintf()
If there actually exist any such systems, they get to manage without floating point output.