ngtcp2: stabilize recv - #20220
Closed
icing wants to merge 2 commits into
Closed
Conversation
When receiving on a stream that already failed or has already been closed, return the matching error code without touching the connection. In case the connection shows errors, e.g. the server closed, those errors should not have impact on an already failed/closed stream. This might mitigate flakiness in pytest 07_13 where unexpected errors occur after a successful upload.
bagder
approved these changes
Jan 8, 2026
Member
|
augment review |
🤖 Augment PR SummarySummary: Stabilizes HTTP/3 recv handling for the ngtcp2 backend by preferring already-known per-stream outcomes over later connection-level errors. Changes:
Technical Notes: Intended to mitigate flakiness (e.g. pytest 07_13) where late connection errors after a successful upload could incorrectly affect an already failed/closed stream. 🤖 Was this summary useful? React with 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When receiving on a stream that already failed or has already been closed, return the matching error code without touching the connection. In case the connection shows errors, e.g. the server closed, those errors should not have impact on an already failed/closed stream.
This might mitigate flakiness in pytest 07_13 where unexpected errors occur after a successful upload.