tool_operate: remove 'else' for VMS #20221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems malplaced as it then avoids the following logic when invoked from a VMS shell and that seems unlikely to be desired. Based on code review. I have no system to try this on. Follow-up to f1261bc
There was a problem hiding this comment.
Pull request overview
This PR removes a misplaced else statement following a VMS-specific preprocessor block, ensuring that error handling logic executes correctly on VMS systems. The change is a follow-up to commit f1261bc and fixes a control flow issue where the removed else was preventing subsequent error handling code from running when invoked from a VMS shell.
Key Changes:
- Removed the
elsekeyword that was incorrectly positioned after the#endifof a VMS-specific conditional compilation block - Adjusted indentation of the error handling logic to reflect the corrected control flow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems malplaced as it then avoids the following logic when invoked from a VMS shell and that seems unlikely to be desired.
Based on code review. I have no system to try this on.
Follow-up to f1261bc