Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolvers: only include anything if needed #2023

Merged
merged 1 commit into from Oct 27, 2017

Conversation

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Oct 26, 2017

This avoids warnings about unused stuff (both warnings about e.g. macros not being used and warnings in unused system includes, specifically the Windows SDK).

bagder
bagder approved these changes Oct 27, 2017
This avoids warnings about unused stuff.

Closes curl#2023
@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Oct 27, 2017

CI failure is unrelated (hanging test).

Loading

@MarcelRaad MarcelRaad merged commit 7331904 into curl:master Oct 27, 2017
2 of 3 checks passed
Loading
@MarcelRaad MarcelRaad deleted the res_includes branch Oct 27, 2017
@jay
Copy link
Member

@jay jay commented Oct 27, 2017

CI failure is unrelated (hanging test).

I've seen a few of those hanging HTTP CONNECT tests, that might be something (though I agree it's unrelated). Does anyone know of an easy way to aggregate which tests have failed in each CI instance? Right now I'm clicking on each individual test and scrolling to the error.

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants