New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolvers: only include anything if needed #2023

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
3 participants
@MarcelRaad
Member

MarcelRaad commented Oct 26, 2017

This avoids warnings about unused stuff (both warnings about e.g. macros not being used and warnings in unused system includes, specifically the Windows SDK).

@bagder

bagder approved these changes Oct 27, 2017

resolvers: only include anything if needed
This avoids warnings about unused stuff.

Closes #2023
@MarcelRaad

This comment has been minimized.

Show comment
Hide comment
@MarcelRaad

MarcelRaad Oct 27, 2017

Member

CI failure is unrelated (hanging test).

Member

MarcelRaad commented Oct 27, 2017

CI failure is unrelated (hanging test).

@MarcelRaad MarcelRaad merged commit 7331904 into curl:master Oct 27, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 74.002%
Details

@MarcelRaad MarcelRaad deleted the MarcelRaad:res_includes branch Oct 27, 2017

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Oct 27, 2017

Member

CI failure is unrelated (hanging test).

I've seen a few of those hanging HTTP CONNECT tests, that might be something (though I agree it's unrelated). Does anyone know of an easy way to aggregate which tests have failed in each CI instance? Right now I'm clicking on each individual test and scrolling to the error.

Member

jay commented Oct 27, 2017

CI failure is unrelated (hanging test).

I've seen a few of those hanging HTTP CONNECT tests, that might be something (though I agree it's unrelated). Does anyone know of an easy way to aggregate which tests have failed in each CI instance? Right now I'm clicking on each individual test and scrolling to the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment