Conversation
|
augment review |
🤖 Augment PR SummarySummary: This PR modernizes curl’s internal 64-bit handling by removing legacy Changes:
Technical Notes: Assumes a 64-bit 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Pull request overview
This pull request modernizes curl's codebase by replacing compiler-specific long long / unsigned long long types with standard C99 int64_t / uint64_t types. The PR removes support for platforms without 64-bit type support, including Plan 9.
Key changes:
- Replaced
long longandunsigned long longwithint64_tanduint64_tthroughout the codebase - Removed
config-plan9.hconfiguration file for Plan 9 platform (which lacked working 64-bit support) - Removed
HAVE_LONGLONGandSIZEOF_LONG_LONGconfiguration checks from build systems (autoconf, CMake, VMS) - Simplified type handling in
lib/mprintf.c,lib/sha256.c, and test utilities
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/sha256.c | Replace unsigned long long / unsigned __int64 with uint64_t in WPA_PUT_BE64 macro and sha256_state struct |
| lib/mprintf.c | Replace mp_intmax_t/mp_uintmax_t typedefs with direct int64_t/uint64_t usage |
| tests/libtest/testutil.c | Simplify rlim_t formatting logic (contains bug - see comments) |
| lib/config-plan9.h | Delete entire Plan 9 configuration file |
| lib/config-mac.h | Remove TYPE_LONGLONG conditional and unconditionally set SIZEOF_CURL_OFF_T to 8 |
| lib/config-os400.h | Remove HAVE_LONGLONG and SIZEOF_LONG_LONG definitions |
| lib/config-riscos.h | Remove SIZEOF_LONG_LONG definition |
| lib/config-win32.h | Remove HAVE_LONGLONG definition |
| lib/curl_config-cmake.h.in | Remove HAVE_LONGLONG and SIZEOF_LONG_LONG cmake defines |
| lib/Makefile.am | Remove config-plan9.h from EXTRA_DIST |
| configure.ac | Remove AC_CHECK_TYPE check for long long |
| CMakeLists.txt | Remove SIZEOF_LONG_LONG size check and HAVE_LONGLONG set logic |
| CMake/unix-cache.cmake | Remove HAVE_LONGLONG cache setting |
| packages/vms/config_h.com | Remove LONGLONG and SIZEOF_LONG_LONG code generation |
| m4/curl-wolfssl.m4 | Remove SIZEOF_LONG and SIZEOF_LONG_LONG undef workarounds and CURL_SIZEOF(long long) call |
| .github/scripts/cmp-config.pl | Remove SIZEOF_LONG_LONG from ignored differences |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove config-plan9.h because it does not support 64 bit, meaning it has not been working for years.
|
Is there an upside keeping the It seemed to have relied on |
|
Nah, we should remove it |
Would need 64-bit support. Ref: #20233 (comment) Follow-up to 0159100 #20233 Closes #20243
Remove config-plan9.h because it does not support 64 bit, meaning it has not been working for years.