New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_setup: Improve detection of CURL_WINDOWS_APP #2025

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mstorsjo
Contributor

mstorsjo commented Oct 27, 2017

If WINAPI_FAMILY is defined, it should be safe to try to include
winapifamily.h to check what the define evaluates to.

This should fix detection of CURL_WINDOWS_APP if building with
_WIN32_WINNT set to 0x0600.

curl_setup: Improve detection of CURL_WINDOWS_APP
If WINAPI_FAMILY is defined, it should be safe to try to include
winapifamily.h to check what the define evaluates to.

This should fix detection of CURL_WINDOWS_APP if building with
_WIN32_WINNT set to 0x0600.
@bagder

This comment has been minimized.

Member

bagder commented Oct 27, 2017

Oh, that looks neat. You agree with this @MarcelRaad ?

@MarcelRaad

This comment has been minimized.

Member

MarcelRaad commented Oct 27, 2017

This doesn't hurt, but note that you never want to target anything lower than Windows 8 as minimum OS when building for Windows Store/Phone/Universal as some replacements for removed functions are not available then and such an application cannot run on anything lower than Windows 8 anyway.

curl doesn't use those functions at the moment, so this would be OK even when targeting Vista. It would only cause Curl_verify_windows_version to return a lower Windows version than necessary.

@bagder

This comment has been minimized.

Member

bagder commented Oct 27, 2017

thanks!

@bagder bagder closed this in 9e76dbe Oct 27, 2017

@mstorsjo mstorsjo deleted the mstorsjo:detect-win-app branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment