altsvc: only accept 17 bytes dates from files#20259
Closed
Conversation
bagder
force-pushed
the
bagder/altsvc-date
branch
from
19891e9 to
ab45700
Compare
bagder
added a commit
that referenced
this pull request
Jan 12, 2026
Since the date format is fixed there is no need to accept more data. Update test355 to verify reject of too long date in alt-svc file This test case was originally supposed to verify alt-svc loading from a file but never did because it was done incorrectly. Now it verifies that a too long date in the input file makes curl disregard the entry. Closes #20259
bagder
force-pushed
the
bagder/altsvc-date
branch
from
3a1e3ce to
e54696a
Compare
bagder
changed the title
Since the date format is fixed there is no need to accept more data. Update test355 to verify reject of too long date in alt-svc file This test case was originally supposed to verify alt-svc loading from a file but never did because it was done incorrectly. Now it verifies that a too long date in the input file makes curl disregard the entry. Closes #20259
Member
Author
|
augment review |
🤖 Augment PR SummarySummary: Constrains alt-svc cache-file expiry dates to the fixed 17-byte 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
If the date is accepted, it connects to the wrong host and fails the test.
bagder
force-pushed
the
bagder/altsvc-date
branch
from
e54696a to
24e9e0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the date format is fixed there is no need to accept more data.
Update test355 to verify reject of too long date in alt-svc file
This test case was originally supposed to verify alt-svc loading from a
file but never did because it was done incorrectly.
Now it verifies that a too long date in the input file makes curl
disregard the entry.
Closes #20259