Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mkhelp.pl: support reproducible build #2026
If the environment contains SOURCE_DATE_EPOCH, generate output such as:
Instead of the usual output based on the current date such as:
This will improve reproducibility. The generated string is only
Signed-off-by: Juro Bystricky firstname.lastname@example.org
From what I'm reading isn't that variable part of a spec that is supposed to have the seconds in it. See https://reproducible-builds.org/specs/source-date-epoch/
I don't see "date unspecified" covered (though I just did some cursory searching).
Yes, SOURCE_DATE_EPOCH does contain an "epoch" value. So it is tempting to print that value instead of the build time. However, I replicated the approach I have seen in openssl, where they issue an identical message: "reproducible build: date unspecified". Claiming that the "Generation time" is the time specified by SOURCE_DATE_EPOCH would not be entirely true.
Do not generate line with the current date, such as: * Generation time: Tue Oct-24 18:01:41 2017 This will improve reproducibility. The generated string is only part of a comment, so there should be no adverse consequences. Signed-off-by: Juro Bystricky <email@example.com>