checksrc: warn for leading spaces before the hash#20282
Closed
checksrc: warn for leading spaces before the hash#20282
Conversation
Fix the 40+ fallouts
There was a problem hiding this comment.
Pull request overview
This PR adds a new checksrc warning to detect and fix leading spaces before preprocessor directives (the # symbol). The PR implements the warning check and fixes all 40+ instances of this style violation found in the codebase.
Changes:
- Added CPPSPACE warning to checksrc.pl to detect leading spaces before preprocessor hash symbols
- Fixed all instances of improperly indented preprocessor directives across library files
- Updated test expectations to reflect the new warning
Reviewed changes
Copilot reviewed 2 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/checksrc.pl | Added CPPSPACE warning and detection logic for leading spaces before # |
| tests/data/test1185 | Updated test expectations to include new CPPSPACE warning and incremented warning count |
| lib/vssh/libssh.c | Removed leading spaces from preprocessor directives |
| lib/vquic/curl_ngtcp2.c | Removed leading spaces from #error directive |
| lib/sha256.c | Removed leading spaces from preprocessor directives |
| lib/md5.c | Removed leading spaces from preprocessor directives |
| lib/md4.c | Removed leading spaces from nested preprocessor directives (using # define convention) |
| lib/http_negotiate.c | Removed leading spaces from preprocessor directives |
| lib/file.c | Removed leading spaces from preprocessor directives |
| lib/curl_ntlm_core.c | Removed leading spaces from nested preprocessor directives (using # define convention) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the 40+ fallouts