digest: handle quotes in the path

[bagder]

The 'uri' component needs to be escaped as well.

Also, use goto as a general error mechanism.

Make test 64 use a double quote in the URL.

[Copilot]

Pull request overview

This pull request adds quote and backslash escaping for the URI component in HTTP Digest authentication headers and refactors error handling to use a goto-based cleanup pattern.

Changes:

• Refactored auth_digest_string_quoted() to use dynamic buffers instead of pre-calculated allocation
• Updated auth_create_digest_http_message() to use goto-based error handling for cleanup
• Added URI escaping for the digest authentication Authorization header
• Modified test64 to include a double quote character in the URL path to verify the escaping functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
tests/data/test64	Updated test case to include a double quote in the URL and updated expected Authorization header and response hash
lib/vauth/digest.c	Refactored string quoting function and digest message creation with improved error handling and URI escaping

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[bagder]

augment review

[augmentcode]

🤖 Augment PR Summary

Summary: This PR improves HTTP Digest auth header generation when the request path contains quote/backslash characters.

Changes:

• Reworks quoted-string escaping in lib/vauth/digest.c to use dynbuf rather than manual size pre-calculation.
• Escapes the Digest uri= parameter so embedded " or \\ in the path are represented correctly inside the quoted-string.
• Refactors auth_create_digest_http_message() error handling to use a single cleanup label and builds the header value via curlx_dyn_addf().
• Updates test 64 to include a double quote in the URL and adjusts the expected request line, Digest uri field, and response hash accordingly.

Technical Notes: The Digest uri value is now escaped specifically for header quoting, while the digest hash still uses the raw request URI bytes (as sent in the request line).

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestions posted.

Comment augment review to trigger a new review at any time.