examples: omit forward declarations, apply misc fixes#20296
examples: omit forward declarations, apply misc fixes#20296vszakats wants to merge 9 commits intocurl:masterfrom
Conversation
|
@vszakats my feedback on the clang format style used on evhiperfifo.c: The leading comments should be indented by one space -This is purely a demo app, all retrieved data is simply discarded by the write
-callback.
+ This is purely a demo app, all retrieved data is simply discarded by the write
+ callback.Continued C expressions should be indented two steps: int action = ((revents & EV_READ) ? CURL_POLL_IN : 0) |
- ((revents & EV_WRITE) ? CURL_POLL_OUT : 0);
+ ((revents & EV_WRITE) ? CURL_POLL_OUT : 0);I'm not saying we should change this now. I just want to highlight that I don't think this clang format config is perfect. |
I rarely let clang-format touch comments, and did not change these -This is purely a demo app, all retrieved data is simply discarded by the write
-callback.
+ * This is purely a demo app, all retrieved data is simply discarded by the write
+ * callback.and have the I used this to verify: (only gipher.c has it, and another source, that I fixed locally last week,
Indeed, I gave in to clang-format in this case, because both were I'll be sticking to the other style. |
|
PR fixing the comments (and more, I had pending locally): #20361 |
ephiperfifo.candevhiperfifo.c.calloc()return value.