Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memdebug: use send/recv signature for curl_dosend/curl_dorecv #2031

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

MarcelRaad commented Oct 29, 2017

This avoids build errors and warnings caused by implicit casts, notably on Windows.

I hope I got the comment in ad164ec#commitcomment-25215855 right that we can do it this way.
An alternative would be to use curl_socket_t for the first argument and just use casts to the *_TYPE_ARG_* types in the send/recv macro definition as well as the function definition.

This avoids build errors and warnings caused by implicit casts.
@bagder
bagder approved these changes Oct 30, 2017
@MarcelRaad

This comment has been minimized.

Copy link
Member Author

MarcelRaad commented Oct 30, 2017

Thanks for the review!

@MarcelRaad MarcelRaad deleted the MarcelRaad:memdebug_send_recv branch Oct 30, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.