mbedtls: remove pinnedpubkey support if MBEDTLS_SSL_KEEP_PEER_CERTIFICATE is not defined#20319
Closed
MAntoniak wants to merge 1 commit intocurl:masterfrom
Closed
mbedtls: remove pinnedpubkey support if MBEDTLS_SSL_KEEP_PEER_CERTIFICATE is not defined#20319MAntoniak wants to merge 1 commit intocurl:masterfrom
MAntoniak wants to merge 1 commit intocurl:masterfrom
Conversation
vszakats
reviewed
Jan 14, 2026
lib/vtls/mbedtls.c
Outdated
| } | ||
|
|
||
| #if defined(MBEDTLS_PK_WRITE_C) && defined(MBEDTLS_SSL_KEEP_PEER_CERTIFICATE) | ||
| #define PINNED_PUBKEY_SUPPORTED |
Member
There was a problem hiding this comment.
Suggested change
| #define PINNED_PUBKEY_SUPPORTED | |
| #define HAVE_PINNED_PUBKEY |
To align with internal names used in similar cases.
MAntoniak
force-pushed
the
mbedtls_pinnedpubkey
branch
from
7afac48 to
efdca85
Compare
vszakats
changed the title
Member
|
I think the |
…CATE is not defined. Behavior similar to when MBEDTLS_PK_WRITE_C is not defined.
MAntoniak
force-pushed
the
mbedtls_pinnedpubkey
branch
from
efdca85 to
08a0ecc
Compare
Contributor
Author
Yes, indeed. I've toggled off this flag already. |
bagder
approved these changes
Jan 15, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior similar to when MBEDTLS_PK_WRITE_C is not defined.