Finish curlx_tvnow rename; provide backward-compatible curlx names #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but why do we want those names preserved? |
|
I figured we need them because INTERNALS.md says that they are provided. I did not think I know enough to modify INTERNALS.md, as I don't know what your plans for these functions are. |
|
Aha, ok so now they're no longer mentioned in INTERNALS since 647f9ae =) |
|
Should curlx.h even include timeval.h anymore? |
|
Good point, I forgot about that file. No, it shouldn't. I'll clean that up as well. Thanks! |
bagder
added a commit
that referenced
this pull request
Oct 30, 2017
Pointed-out-by: Dmitri Tikhonov Bug: #2034
|
Closing: nothing to do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.