Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Finish curlx_tvnow rename; provide backward-compatible curlx names #2034
Conversation
dtikhonov
added some commits
Oct 30, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
but why do we want those names preserved? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dtikhonov
Oct 30, 2017
Contributor
I figured we need them because INTERNALS.md says that they are provided. I did not think I know enough to modify INTERNALS.md, as I don't know what your plans for these functions are.
|
I figured we need them because INTERNALS.md says that they are provided. I did not think I know enough to modify INTERNALS.md, as I don't know what your plans for these functions are. |
|
Aha, ok so now they're no longer mentioned in INTERNALS since 647f9ae =) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Should curlx.h even include timeval.h anymore? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bagder
Oct 30, 2017
Member
Good point, I forgot about that file. No, it shouldn't. I'll clean that up as well. Thanks!
|
Good point, I forgot about that file. No, it shouldn't. I'll clean that up as well. Thanks! |
added a commit
that referenced
this pull request
Oct 30, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Closing: nothing to do. |
dtikhonov commentedOct 30, 2017
No description provided.