Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish curlx_tvnow rename; provide backward-compatible curlx names #2034

Closed
wants to merge 2 commits into from
Closed

Finish curlx_tvnow rename; provide backward-compatible curlx names #2034

wants to merge 2 commits into from

Conversation

@dtikhonov
Copy link
Contributor

dtikhonov commented Oct 30, 2017

No description provided.

dtikhonov added 2 commits Oct 30, 2017
@dtikhonov
Merge pull request #1 from curl/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
74b4ac1 
Get head
@dtikhonov
Provide curlx_tv* defines in curlx.h; fix related comments
Loading status checks…
ab32480
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member

bagder commented Oct 30, 2017

but why do we want those names preserved?
@dtikhonov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

dtikhonov commented Oct 30, 2017

I figured we need them because INTERNALS.md says that they are provided. I did not think I know enough to modify INTERNALS.md, as I don't know what your plans for these functions are.
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member

bagder commented Oct 30, 2017

Aha, ok so now they're no longer mentioned in INTERNALS since 647f9ae =)
@dtikhonov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

dtikhonov commented Oct 30, 2017 •
edited

Should curlx.h even include timeval.h anymore?
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member

bagder commented Oct 30, 2017

Good point, I forgot about that file. No, it shouldn't. I'll clean that up as well. Thanks!
bagder added a commit that referenced this pull request Oct 30, 2017
@bagder
curlx: the timeval functions are no longer provided as curlx_*
Loading status checks…
a7b99d5 
Pointed-out-by: Dmitri Tikhonov
Bug: #2034
@dtikhonov

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

dtikhonov commented Oct 30, 2017

Closing: nothing to do.
@dtikhonov dtikhonov closed this Oct 30, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@dtikhonov @bagder
You can’t perform that action at this time.