Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFinish curlx_tvnow rename; provide backward-compatible curlx names #2034
Conversation
dtikhonov
added some commits
Oct 30, 2017
This comment has been minimized.
This comment has been minimized.
|
but why do we want those names preserved? |
This comment has been minimized.
This comment has been minimized.
|
I figured we need them because INTERNALS.md says that they are provided. I did not think I know enough to modify INTERNALS.md, as I don't know what your plans for these functions are. |
This comment has been minimized.
This comment has been minimized.
|
Aha, ok so now they're no longer mentioned in INTERNALS since 647f9ae =) |
This comment has been minimized.
This comment has been minimized.
|
Should curlx.h even include timeval.h anymore? |
This comment has been minimized.
This comment has been minimized.
|
Good point, I forgot about that file. No, it shouldn't. I'll clean that up as well. Thanks! |
added a commit
that referenced
this pull request
Oct 30, 2017
This comment has been minimized.
This comment has been minimized.
|
Closing: nothing to do. |
dtikhonov
closed this
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dtikhonov commentedOct 30, 2017
No description provided.