New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish curlx_tvnow rename; provide backward-compatible curlx names #2034

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@dtikhonov
Contributor

dtikhonov commented Oct 30, 2017

No description provided.

dtikhonov added some commits Oct 30, 2017

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Oct 30, 2017

Member

but why do we want those names preserved?

Member

bagder commented Oct 30, 2017

but why do we want those names preserved?

@dtikhonov

This comment has been minimized.

Show comment
Hide comment
@dtikhonov

dtikhonov Oct 30, 2017

Contributor

I figured we need them because INTERNALS.md says that they are provided. I did not think I know enough to modify INTERNALS.md, as I don't know what your plans for these functions are.

Contributor

dtikhonov commented Oct 30, 2017

I figured we need them because INTERNALS.md says that they are provided. I did not think I know enough to modify INTERNALS.md, as I don't know what your plans for these functions are.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Oct 30, 2017

Member

Aha, ok so now they're no longer mentioned in INTERNALS since 647f9ae =)

Member

bagder commented Oct 30, 2017

Aha, ok so now they're no longer mentioned in INTERNALS since 647f9ae =)

@dtikhonov

This comment has been minimized.

Show comment
Hide comment
@dtikhonov

dtikhonov Oct 30, 2017

Contributor

Should curlx.h even include timeval.h anymore?

Contributor

dtikhonov commented Oct 30, 2017

Should curlx.h even include timeval.h anymore?

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Oct 30, 2017

Member

Good point, I forgot about that file. No, it shouldn't. I'll clean that up as well. Thanks!

Member

bagder commented Oct 30, 2017

Good point, I forgot about that file. No, it shouldn't. I'll clean that up as well. Thanks!

bagder added a commit that referenced this pull request Oct 30, 2017

@dtikhonov

This comment has been minimized.

Show comment
Hide comment
@dtikhonov

dtikhonov Oct 30, 2017

Contributor

Closing: nothing to do.

Contributor

dtikhonov commented Oct 30, 2017

Closing: nothing to do.

@dtikhonov dtikhonov closed this Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment