hostip: fix unreachable code in rare build configuration#20344
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
hostip: fix unreachable code in rare build configuration#20344vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
cmake options:
```
-DCMAKE_UNITY_BUILD=OFF -DCURL_DISABLE_HTTP=ON -DENABLE_THREADED_RESOLVER=OFF
```
Fixing:
```
lib/hostip.c:939:16: error: code will never be executed [-Werror,-Wunreachable-code]
940 | *entry = dns;
| ^~~
```
This comment has been minimized.
This comment has been minimized.
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jan 18, 2026
Seen in trurl builds with no IMAP. Refs: curl/curl@aef128e curl/curl#20344
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jan 18, 2026
The upstream patch is no longer important, after disabling unity for macOS trurl builds again. Refs: curl/curl@aef128e curl/curl#20344 Follow-up to d4abe8f859974af1ea3918b73f538deb8f6587c2 Follow-up to 922e754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with cmake options:
Fixing (seen with Apple clang 17):