setopt: return CURLE_NOT_BUILT_IN for unsupported SSL options#20364
Closed
Frank-Buss wants to merge 3 commits intocurl:masterfrom
Closed
setopt: return CURLE_NOT_BUILT_IN for unsupported SSL options#20364Frank-Buss wants to merge 3 commits intocurl:masterfrom
Frank-Buss wants to merge 3 commits intocurl:masterfrom
Conversation
bagder
reviewed
Jan 20, 2026
Contributor
Author
|
Right, logically we should probably add another flag for it, I added a new commit. |
bagder
approved these changes
Jan 20, 2026
Member
|
Thanks! |
charles2910
added a commit
to charles2910/pycurl
that referenced
this pull request
Feb 26, 2026
CURLOPT_ISSUERCERT_BLOB is only available with the openssl backend [1], but up until 8.19.0-rc1 it would not fail the test. After d7bbc783601 was merged [2], it started to report correctly options that were not supported by the backend libcurl was built with. [1] https://curl.se/libcurl/c/CURLOPT_ISSUERCERT_BLOB.html [2] curl/curl#20364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSL options CURLOPT_ISSUERCERT, CURLOPT_SSL_EC_CURVES, and CURLOPT_CRLFILE were silently accepted by curl_easy_setopt() even when the SSL backend doesn't support them. This could mislead applications into believing security features are active when they're not.
This PR adds Curl_ssl_supports() checks for these options, consistent with how other SSL options like CURLOPT_PINNEDPUBLICKEY and CURLOPT_SSL_SIGNATURE_ALGORITHMS are already handled.
Tested with mbedTLS and OpenSSL backends. After this change, unsupported options return CURLE_NOT_BUILT_IN instead of silently succeeding.