build: drop global suppression of -Wformat-nonliteral, fix fallouts#20366
Closed
vszakats wants to merge 12 commits intocurl:masterfrom
Closed
build: drop global suppression of -Wformat-nonliteral, fix fallouts#20366vszakats wants to merge 12 commits intocurl:masterfrom
-Wformat-nonliteral, fix fallouts#20366vszakats wants to merge 12 commits intocurl:masterfrom
Conversation
This reverts commit 57a37ce.
1 task
-Wformat-nonliteral-Wformat-nonliteral, fix fallouts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend two existing local suppressions to GCC, and add another
GCC-specific one as a replacement.
Before this patch suppressing this warning was odd with clang, because
after this option,
-Wformat=2is used, which re-enables it.Also:
vsnprintf()callwhere it could trigger in C89 builds or with
CFLAGS=-DCURL_NO_FMT_CHECKSset. Seen with Apple clang 17:Ref: #20363