build: drop global suppression of -Wformat-nonliteral, fix fallouts - #20366
Closed
vszakats wants to merge 12 commits into
Closed
build: drop global suppression of -Wformat-nonliteral, fix fallouts#20366vszakats wants to merge 12 commits into
-Wformat-nonliteral, fix fallouts#20366vszakats wants to merge 12 commits into
Conversation
This reverts commit 57a37ce.
1 task
-Wformat-nonliteral-Wformat-nonliteral, fix fallouts
vszakats
added a commit
that referenced
this pull request
Mar 12, 2026
- tool_getparam: revert an unnecessary/no-op C89 warning silencer. Follow-up to 09c9afd #20363 - tool_writeout: add comment saying silencing is a no-op for llvm/clang. For `strftime()` it is a GCC-specific, as of llvm/clang v22.1.0. Follow-up to f07a98a #20366 - unit1652: drop always-false `!defined(__clang__)` guard. Pointed-out-by: Orgad Shaneh Ref: #20902 Follow-up to 7e814c8 #16062 - unit1652: document that `-Wformat` is necessary for GCC v5 to v8. Follow-up to 71cf0d1 #14772 Closes #20908
4 tasks
vszakats
added a commit
that referenced
this pull request
Mar 18, 2026
…warnings Extend `#pragma diagnostic push`/`pop` guards to the whole codebase (from tests and examples only) to disable it for GCC <4.6. Rename guard to `CURL_HAVE_DIAG` and make it include llvm/clang to be interchangeable with `__GNUC__ || __clang__` in this context. The above means no longer disabling certain warnings locally, so pair this with disabling all picky warnings for GCC <4.6. Also: - drop global workarounds for misbehaving GCC <4.6 compiler warnings. Not needed with picky warnings disabled. Reported-by: fds242 on github Reported-by: Sergey Fedorov Thanks-to: Orgad Shaneh Follow-up to f07a98a #20366 Fixes #20892 Fixes #20924 Closes #20902 Closes #20907
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
- tool_getparam: revert an unnecessary/no-op C89 warning silencer. Follow-up to 09c9afd curl#20363 - tool_writeout: add comment saying silencing is a no-op for llvm/clang. For `strftime()` it is a GCC-specific, as of llvm/clang v22.1.0. Follow-up to f07a98a curl#20366 - unit1652: drop always-false `!defined(__clang__)` guard. Pointed-out-by: Orgad Shaneh Ref: curl#20902 Follow-up to 7e814c8 curl#16062 - unit1652: document that `-Wformat` is necessary for GCC v5 to v8. Follow-up to 71cf0d1 curl#14772 Closes curl#20908
outcast36
pushed a commit
to greearb/curl
that referenced
this pull request
Jun 3, 2026
…warnings Extend `#pragma diagnostic push`/`pop` guards to the whole codebase (from tests and examples only) to disable it for GCC <4.6. Rename guard to `CURL_HAVE_DIAG` and make it include llvm/clang to be interchangeable with `__GNUC__ || __clang__` in this context. The above means no longer disabling certain warnings locally, so pair this with disabling all picky warnings for GCC <4.6. Also: - drop global workarounds for misbehaving GCC <4.6 compiler warnings. Not needed with picky warnings disabled. Reported-by: fds242 on github Reported-by: Sergey Fedorov Thanks-to: Orgad Shaneh Follow-up to f07a98a curl#20366 Fixes curl#20892 Fixes curl#20924 Closes curl#20902 Closes curl#20907
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend two existing local suppressions to GCC, and add another
GCC-specific one as a replacement.
Before this patch suppressing this warning was odd with clang, because
after this option,
-Wformat=2is used, which re-enables it.Also:
vsnprintf()callwhere it could trigger in C89 builds or with
CFLAGS=-DCURL_NO_FMT_CHECKSset. Seen with Apple clang 17:Ref: #20363